-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should available quantities and entries in parser be None if not available #532
Comments
@espenfl , What do you mean "all quantities"? User's |
The question is what does not parsable mean? |
I mean every single quantity we return. That could be the main quantity that is requested, e.g. |
Yes, and since we can try different parsers for the same quantity an exception should only be raised when we have exhausted all options. And for quantities that then is not being able to be parser by a specific content parser, should we return |
"quantity" is used in different meaning in different context. This is what I needed to struggle most in my previous refactoring of parser. I wrote memo about it here, https://github.com/aiida-vasp/aiida-vasp/wiki/Memo-on-parser#variable-names. I didn't change the original variable names but probably now it is better to define obvious names. If I remember correctly, currently parser is made of a series of screenings, plus |
Yes, we should at least review and make sure to do any changes that makes logical sense.
We are not yet discussing the screening or |
I could not understand your question until here. |
Should we make all quantities
None
if they are not parsable. This also includes sub-elements in dicts. I would at least like this to be consistent and it would be hard to do for something else thanNone
. UsingNone
can cause issues and a bit more boilerplate than necessary, but then we at least know that if we detectNone
it is not parsed. @atztogo @zhubonan @JPchico what do you think?The text was updated successfully, but these errors were encountered: