Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly.yml #674

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Update nightly.yml #674

merged 2 commits into from
Aug 18, 2023

Conversation

zhubonan
Copy link
Member

Please check the applicable boxes, thank you:

I, the author consider this PR

  • ready to be reviewed and merged (as soon as tests have passed)
  • work in progress (early feedback welcome)

Remove 3.8 for the nightly run as it is no longer supported.

Interactions with issues / other PRs

type "#" followed by search words to find issues / PRs

fixes:

blocks:

is blocked by:

None of the above but is still related to the following:

Description

JPchico
JPchico previously approved these changes Aug 18, 2023
Copy link
Collaborator

@JPchico JPchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should we include python 3.11?

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (379b819) 72.89% compared to head (2bd5f03) 72.89%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #674   +/-   ##
========================================
  Coverage    72.89%   72.89%           
========================================
  Files           58       58           
  Lines         7206     7206           
========================================
  Hits          5252     5252           
  Misses        1954     1954           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JPchico JPchico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@espenfl
Copy link
Collaborator

espenfl commented Aug 18, 2023

Thanks a lot @zhubonan and @JPchico.

@espenfl espenfl merged commit ace503f into develop Aug 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants