Porting fixes for ACWF v1.0 to the develop branch
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A commit that deviates from develop branch to offer support for core v1, in additions to extentions to the error handlers that was needed for the ACWF study. These are disabled by default, but can be enabled. Pylint etc. has also been disabled. Cherry-pick: acc2a71
sphuber
force-pushed
the
fix/acwf-handlers
branch
from
cc36e5b
to
db6dcff
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #679 +/- ##
===========================================
- Coverage 72.89% 72.13% -0.75%
===========================================
Files 58 58
Lines 7206 7329 +123
===========================================
+ Hits 5252 5286 +34
- Misses 1954 2043 +89 ☔ View full report in Codecov by Sentry. |
zhubonan
approved these changes
Dec 20, 2023
|
Thanks @sphuber! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of acc2a71 which was released with
v2.2.0but was never added to the main branch. As a result, theaiida-common-workflowsnow fail withaiida-vasp>=3.0which is necessary for AiiDA v2.0 compatibility. The commit in question added specific handlers for theVaspWorkChainthat are missing inaiida-vaspv3.0. This is restored by cherry-picking the commit.Please check the applicable boxes, thank you:
I, the author consider this PR
Interactions with issues / other PRs
type "#" followed by search words to find issues / PRs
fixes:
blocks:
is blocked by:
None of the above but is still related to the following:
Description