Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to additional flags/override existing ones #107

Open
louisponet opened this issue Jul 28, 2021 · 3 comments
Open

Access to additional flags/override existing ones #107

louisponet opened this issue Jul 28, 2021 · 3 comments

Comments

@louisponet
Copy link
Member

The idea is to allow expert users in "expert mode" access to specify additional flags or override already specified ones by the protocol.

One way this could be achieved is through some small editor-type field where the user can specify a Dict-like structure (either an actual python Dict, or yaml or json), which will then be merged with the default one defined by the protocol.

@louisponet louisponet added the enhancement New feature or request label Jul 28, 2021
@csadorf
Copy link
Member

csadorf commented Jul 28, 2021

I like this idea in principle. One thing to keep in mind is that we have to parse those dictionaries also on workflow load, which could pose a challenge.

@csadorf
Copy link
Member

csadorf commented Nov 3, 2021

@mbercx Is this in principle possible?

@mbercx
Copy link
Member

mbercx commented Nov 4, 2021

Sure, this is possible, since the get_builder_from_protocol() method accepts an overrides input argument. I'd suggest a YAML format, I also use this for defining my overrides since you can pass the Path directly to the overrides input.

It might be a bit challenging for a user to figure out the correct structure of this YAML. We could already provide a basic structure with some null values, that we can pop after loading the YAML file (and then pass is to the overrides input).

Not sure if this should be a priority for the next milestone though. I think integrating the PdosWorkChain and Dou's bandsplot widget is more valuable.

@unkcpz unkcpz added this to the v2024.4.0 milestone Aug 18, 2023
@unkcpz unkcpz modified the milestones: v2024.4.0, v2023.10.x, v2024.10.0 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants