Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 FIX: Make POSITIONS_CELL the default selection #58

Closed
mbercx opened this issue Jun 5, 2021 · 1 comment 路 Fixed by #54
Closed

馃悰 FIX: Make POSITIONS_CELL the default selection #58

mbercx opened this issue Jun 5, 2021 · 1 comment 路 Fixed by #54
Assignees
@mbercx
Labels
bug Something isn't working topic/ui
Projects
2021-07

Comments

@mbercx
Copy link
Member

mbercx commented Jun 5, 2021

We should make "POSITIONS_CELL" the default choice for the geometry optimization, since just optimizing the atoms is often not sufficient. I tried to fix this in #54 but this refuses to work 馃槧 . Shouldn't we just add a value argument to the Dropdown?
@mbercx mbercx added bug Something isn't working topic/ui labels Jun 5, 2021
@mbercx mbercx added this to To do in 2021-07 via automation Jun 5, 2021
This was referenced Jun 5, 2021
Closed
Merged
@mbercx mbercx linked a pull request Jun 7, 2021 that will close this issue
馃憣 IMPROVE: Step 2 "Submit Work Chain" UI #54
Merged
@mbercx
Copy link
Member Author

mbercx commented Jun 8, 2021

Closed by #54

@csadorf do you have an idea why this wasn't closed automatically? Did I mess up, or is there some GitHub setting that must be set for this?

@mbercx mbercx closed this as completed Jun 8, 2021
2021-07 automation moved this from To do to Done Jun 8, 2021
@mbercx mbercx assigned mbercx and unassigned csadorf and yakutovicha Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbercx mbercx

Labels
bug Something isn't working topic/ui
Projects
No open projects
2021-07
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

馃憣 IMPROVE: Step 2 "Submit Work Chain" UI mbercx/aiidalab-qe
3 participants
@csadorf @yakutovicha @mbercx