Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 FIX: Structure not showing in the "Final Geometry" tab of the outputs. #69

Closed
mbercx opened this issue Jun 7, 2021 · 7 comments 路 Fixed by #92
Closed

馃悰 FIX: Structure not showing in the "Final Geometry" tab of the outputs. #69

mbercx opened this issue Jun 7, 2021 · 7 comments 路 Fixed by #92
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed priority/critical topic/ui
Projects

Comments

@mbercx
Copy link
Member

mbercx commented Jun 7, 2021

In Step three, the StructureDataViewer in the "Final Geometry" tab is not showing the structure properly. This is most likely related to this issue:

nglviewer/nglview#871

There is a suggested fix there, but I didn't manage to get this to work yet. This may be due to the convoluted logic I implemented to have these Tabs only show up once the results are completed.

@mbercx mbercx added bug Something isn't working help wanted Extra attention is needed topic/ui priority/critical labels Jun 7, 2021
@mbercx mbercx added this to To do in 2021-07 via automation Jun 7, 2021
@yakutovicha
Copy link
Member

I looked into the issue, and it seems that the behaviour remains exactly as it was: the structure is displayed in the first tab, but not displayed in all the others:

Screenshot 2021-06-29 at 11 05 41

@csadorf
Copy link
Member

csadorf commented Jun 29, 2021

I looked into the issue, and it seems that the behaviour remains exactly as it was: the structure is displayed in the first tab, but not displayed in all the others:

Does that mean there is no fix?

@mbercx
Copy link
Member Author

mbercx commented Jun 29, 2021

So it's exactly the same as the issue you encountered, or?

EDIT: Haha, Simon had the same question from a different angle. 馃槄

@yakutovicha
Copy link
Member

I think there is a fix, but it might be an ugly one. Trying to figure it out.

@yakutovicha
Copy link
Member

Yes, it is exactly the same issue that I encountered before.

@mbercx
Copy link
Member Author

mbercx commented Jun 29, 2021

Ugly fixes are better than no fixes. 馃榿

@csadorf csadorf moved this from To do to In progress in 2021-07 Jul 1, 2021
@csadorf csadorf linked a pull request Jul 1, 2021 that will close this issue
@csadorf
Copy link
Member

csadorf commented Jul 1, 2021

Resolved with merge of #92 .

@csadorf csadorf closed this as completed Jul 1, 2021
2021-07 automation moved this from In progress to Done Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed priority/critical topic/ui
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants