RemoteData: Add the is_cleaned property (#6101)

This is a convenience method that will return the `KEY_EXTRA_CLEANED`
extra, which is set to `True` when the `clean` method is called. The
`is_empty` method is also updated to use this new property and shortcut
if set to `True`. This saves the method from having to open a transport
connection.

aiida/orm/nodes/data/remote/base.py

@@ -37,11 +37,19 @@ def get_remote_path(self):
     def set_remote_path(self, val):
         self.base.attributes.set('remote_path', val)
 
+    @property
+    def is_cleaned(self):
+        """Return whether the remote folder has been cleaned."""
+        return self.base.extras.get(self.KEY_EXTRA_CLEANED, False)
+
     @property
     def is_empty(self):
         """
         Check if remote folder is empty
         """
+        if self.is_cleaned:
+            return True
+
         authinfo = self.get_authinfo()
         transport = authinfo.get_transport()
 

tests/orm/nodes/data/test_remote.py

@@ -27,7 +27,8 @@ def remote_data(tmp_path, aiida_localhost):
 def test_clean(remote_data):
     """Test the :meth:`aiida.orm.nodes.data.remote.base.RemoteData.clean` method."""
     assert not remote_data.is_empty
+    assert not remote_data.is_cleaned
 
     remote_data._clean()  #  pylint: disable=protected-access
     assert remote_data.is_empty
-    assert remote_data.base.attributes.get(RemoteData.KEY_EXTRA_CLEANED, True)
+    assert remote_data.is_cleaned