Skip to content

Commit

Permalink
Upgrading dependency of sqlalchemy-utils
Browse files Browse the repository at this point in the history
In sqlalchemy-utils 0.35, imports from collections where correctly
fixed to import from collections.abc (where this is needed).
This removes a few deprecation warnings (claiming that this will not
work in py 3.9, even if in reality this will stop working in py 3.10).
This partially addresses #4723.

We are actually pinning to >=0.36 since in 0.36 a feature was dropped
that we were planning to use (see #3845). In this way, we avoid relying
on a feature that is removed in later versions (risking to implement
something that then we have to remove, or even worse remain "pinned"
to an old version of sqlalchemy-utils because nobody has the time
to fix it with a different implementation [which is tricky, requires
some knowledge of how SqlAlchemy and PosgreSQL work]).
  • Loading branch information
giovannipizzi committed Feb 9, 2021
1 parent 99f988b commit 53079e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies:
- pyyaml~=5.1.2
- reentry~=1.3
- simplejson~=3.16
- sqlalchemy-utils~=0.34.2
- sqlalchemy-utils~=0.36.0
- sqlalchemy>=1.3.10,~=1.3
- tabulate~=0.8.5
- tqdm~=4.45
Expand Down
2 changes: 1 addition & 1 deletion setup.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"pyyaml~=5.1.2",
"reentry~=1.3",
"simplejson~=3.16",
"sqlalchemy-utils~=0.34.2",
"sqlalchemy-utils~=0.36.0",
"sqlalchemy~=1.3,>=1.3.10",
"tabulate~=0.8.5",
"tqdm~=4.45",
Expand Down

3 comments on commit 53079e3

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements/ files are missing dependencies specified in the 'setup.json' file.

setup.json:50: No match for dependency sqlalchemy-utils~=0.36.0 in:

  • requirements/requirements-py-3.7.txt
  • requirements/requirements-py-3.8.txt
  • requirements/requirements-py-3.9.txt

Click here for more information on dependency management.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements/ files are missing dependencies specified in the 'setup.json' file.

setup.json:50: No match for dependency sqlalchemy-utils~=0.36.0 in:

  • requirements/requirements-py-3.7.txt
  • requirements/requirements-py-3.8.txt
  • requirements/requirements-py-3.9.txt

Click here for more information on dependency management.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements/ files are inconsistent!

Please sign in to comment.