Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config.delete_profile does not write changes to file #4921

Closed
sphuber opened this issue May 6, 2021 · 0 comments · Fixed by #4934
Closed

Config.delete_profile does not write changes to file #4921

sphuber opened this issue May 6, 2021 · 0 comments · Fixed by #4934
Assignees
Labels
priority/critical-blocking must be resolved before next release topic/config type/bug
Milestone

Comments

@sphuber
Copy link
Contributor

sphuber commented May 6, 2021

This means that the profile is not removed from the config.json. The method should call self.store() before returning and we should add a test. Tricky part is that in the test we cannot use the Config method to check if the profile still exists, because it won't in memory but we need to check that the file on disk is properly updated as well.

It should also check if the deleted profile was the default, and if so reset it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical-blocking must be resolved before next release topic/config type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant