Improve and fix issues with the plugin loader tests #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WorkflowFactory can be used to load both legacy Workflow classes as well as new style WorkChain workflows. The plugin loader tests were only allowing for legacy Workflow classes to be registered even though the loader works just fine. Therefore we add the WorkChain as an acceptable subclass for classes registered under the aiida.workflows entry point
The plugin loader tests will now try to construct the plugins for the Tcod exporter through the TcodExporterFactory and test whether they are a subclass of the BaseTcodtranslator class
With the new ParserFactory I have also added a tests to the plugin loader for all registered plugins for the aiida.parsers entry point
giovannipizzi
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1023
This addresses the main problem that was outlined in the original issue but I also addressed some other problems:
WorkChainclass as acceptable subclass for plugins inaiida.workflowsentry pointTcodExporterFactoryand added the same plugin loading tests foraiida.tools.dbexporters.tcod_pluginsas for the other entry pointsaiida.parsersentry point mapping to remove the superfluous.pluginssuffix and updated theParserFactoryaccordinglyaiida.parsersentry point