-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #132 - CIF syntax errors from PyCifRW - upgrade to PyCifRW 4.2.1 #1073
Conversation
… syntax of CIF files when a square bracket is put in a value
…RW is not present
…d printouts on the std output. Apply it to all occurences of the CifFile WriteOut method
…e into fix_132_PyCifRW_syntax
Thanks for looking into this! I like the |
…n CIF updated, full strings simplified
for loop in node.values[dataname].loops: | ||
loops[loop.keys()[0]] = loop.keys() | ||
for loop in node.values[dataname].loops.values(): | ||
loops[loop[0]] = loop | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has the syntax really changed from keys to values?
I.e. is the result of this loop unchanged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes (to both). Before, node.values[dataname].loops was a list, now it's a dictionary, whose values correspond to the keys of the previous version (more or less...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels a bit loopy...
anyhow, thanks, just wanted to make sure.
This was merged into develop with PR #1073 but needs to be back ported into release v0.11.4
Fix issue #132: