Save and load the parsed inputs from the persisted state #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_1361_persist_process_parsed_inputs
branch
4 times, most recently
from
d1cea3b
to
d33c707
Compare
This is an issue in plumpy that was also fixed there. The parsed inputs of a Process, which is returned by calling self.inputs, were being rebuilt from the raw inputs everytime the process was loaded from a persisted state. This meant that inputs that were not explicitly passed by the user and were populated with the defaults specified by the port, were being recreated upon reloading the instance. However, they should have been the ones that were created when the process was created the first time around. Therefore we persist the parsed inputs to the saved state and reload them instead of recreating them with `create_input_args`
sphuber
force-pushed
the
fix_1361_persist_process_parsed_inputs
branch
from
d33c707
to
dfa105b
Compare
muhrin
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1361
This is an issue in plumpy that was also fixed there.
The parsed inputs of a Process, which is returned by calling self.inputs,
were being rebuilt from the raw inputs everytime the process was loaded
from a persisted state. This meant that inputs that were not explicitly
passed by the user and were populated with the defaults specified by the
port, were being recreated upon reloading the instance. However, they
should have been the ones that were created when the process was created
the first time around. Therefore we persist the parsed inputs to the saved
state and reload them instead of recreating them with
create_input_args