Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip pgtest related testcases until #1722 is fixed #1724

Merged
merged 1 commit into from Jul 6, 2018

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Jul 6, 2018

No description provided.

@DropD DropD added the priority/critical-blocking must be resolved before next release label Jul 6, 2018
@DropD DropD requested a review from sphuber July 6, 2018 14:15
@sphuber
Copy link
Contributor

sphuber commented Jul 6, 2018

The problem you are having now is with locate, which @giovannipizzi fixed in his open PR 5567283

Probably best if you also add this fix to this commit as both these are "temporary" fixes to get the tests running. I think that should fix the failing test on Travis

@DropD
Copy link
Contributor Author

DropD commented Jul 6, 2018

The actual problem was that i wasn't skipping everything. I think i got them all now.

@codecov-io
Copy link

Codecov Report

Merging #1724 into develop will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1724      +/-   ##
===========================================
- Coverage    57.18%   56.43%   -0.75%     
===========================================
  Files          275      275              
  Lines        33931    33931              
===========================================
- Hits         19402    19148     -254     
- Misses       14529    14783     +254
Impacted Files Coverage Δ
aiida/utils/fixtures.py 37.81% <0%> (-52.24%) ⬇️
aiida/common/setup.py 44.23% <0%> (-24.95%) ⬇️
aiida/backends/sqlalchemy/__init__.py 85.71% <0%> (-14.29%) ⬇️
aiida/cmdline/commands/user.py 69.23% <0%> (-6.42%) ⬇️
.../common/additions/config_migrations/_migrations.py 96.55% <0%> (-3.45%) ⬇️
aiida/common/additions/config_migrations/_utils.py 94.44% <0%> (-2.78%) ⬇️
aiida/control/postgres.py 88.31% <0%> (-2.6%) ⬇️
aiida/cmdline/verdilib.py 68.48% <0%> (-2.11%) ⬇️
aiida/orm/implementation/django/computer.py 79.25% <0%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bca139...62b9c0b. Read the comment docs.

@DropD DropD requested a review from giovannipizzi July 6, 2018 15:42
@DropD DropD requested a review from muhrin July 6, 2018 15:43
@sphuber sphuber merged commit 777c16c into aiidateam:develop Jul 6, 2018
dev-zero added a commit to dev-zero/aiida-core that referenced this pull request Jul 9, 2018
DropD pushed a commit that referenced this pull request Jul 10, 2018
* travis: explicitly install postgresql-server-dev-9.5

Based on travis-ci/travis-ci#9011 it seems we
have to specify explicitly the dependency on the postgresql-dev package
by now.

* Revert "skip pgtest related testcases until #1722 is fixed (#1724)"

This reverts commit 777c16c and fixes #1723

* travis: add proper postgresql bin-dir to path

fixes #1722

* travis: fix ssh-keygen for private instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical-blocking must be resolved before next release topic/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants