Add new command verdi process to interact with running processes
#1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All interactions with processes, now go through RabbitMQ. Historically there is a division in the calculations, where job and inline calculations are managed through `verdi calculation` and the work type calculations through `verdi work`. However, these commands should really only serve to introspect the state of a process through the node that serves as its proxy in the database. Any commands that need to affect the process that these nodes represent, have to go through RabbitMQ. To make this distinction clearer to users, the new command `verdi process` is created. Any command that interacts with the process, such as `kill`, `play` and `pause` should go through `verdi process`. All other commands that only strictly display information about the process through the calculation node proxy, should go in `verdi calculation` and `verdi work`.
sphuber
force-pushed
the
fix_1825_introduce_verdi_process
branch
from
cd2b8a4
to
f9fc184
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1855 +/- ##
===========================================
- Coverage 66.81% 66.78% -0.03%
===========================================
Files 316 320 +4
Lines 32331 32527 +196
===========================================
+ Hits 21602 21724 +122
- Misses 10729 10803 +74
Continue to review full report at Codecov.
|
muhrin
requested changes
Aug 8, 2018
aiida/cmdline/commands/cmd_work.py
Outdated
| @verdi_work.command('kill') | ||
| @arguments.CALCULATIONS( | ||
| type=types.CalculationParamType(sub_classes=('aiida.calculations:work', 'aiida.calculations:function'))) | ||
| def work_kill(calculations): |
There was a problem hiding this comment.
Put back with deprecation warning.
| @@ -517,14 +530,10 @@ Configure and manage users | |||
| -------------- | |||
| Manage work calculations. | |||
|
|
|||
| * **kill**: kill a work calculation | |||
| * **pause**: Pause running processes. | ||
| * **play**: Play paused processes. | ||
| * **watch**: Watch the state transitions for a process. | ||
|
|
muhrin
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1825
All interactions with processes, now go through RabbitMQ. Historically
there is a division in the calculations, where job and inline calculations
are managed through
verdi calculationand the work type calculationsthrough
verdi work. However, these commands should really only serveto introspect the state of a process through the node that serves as its
proxy in the database. Any commands that need to affect the process that
these nodes represent, have to go through RabbitMQ. To make this distinction
clearer to users, the new command
verdi processis created.Any command that interacts with the process, such as
kill,playandpauseshould go throughverdi process. All other commands that onlystrictly display information about the process through the calculation
node proxy, should go in
verdi calculationandverdi work.