Changed type of uuids returned by the QueryBuilder to be unicode #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before returning
sphuber
requested changes
Dec 3, 2018
aiida/backends/tests/nodes.py
Outdated
| @@ -193,6 +193,19 @@ def test_loop_not_allowed(self): | |||
| with self.assertRaises(ValueError): # This would generate a loop | |||
| n1.add_incoming(n4, link_type=LinkType.CREATE, link_label='link') | |||
|
|
|||
| class TestTypes(AiidaTestCase): | |||
| """ | |||
| Test the transitive closure functionality | |||
aiida/backends/tests/nodes.py
Outdated
| @@ -2189,3 +2202,6 @@ def test_delete_called_but_not_caller(self): | |||
| delete_nodes([called.pk], verbosity=2, force=True, follow_returns=True) | |||
|
|
|||
| self._check_existence(uuids_check_existence, uuids_check_deleted) | |||
|
|
|||
| @@ -14,7 +14,7 @@ | |||
| from __future__ import absolute_import | |||
| from datetime import datetime | |||
| from json import loads as json_loads | |||
| import six | |||
| import six, uuid | |||
lekah
changed the title
sphuber
approved these changes
Dec 3, 2018
This was referenced Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231 and fixes #1862