Use ProfileParamType in verdi and expose in ctx.obj
#2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
approved these changes
Dec 12, 2018
sphuber
force-pushed
the
fix_2344_verdi_profile_param_type
branch
from
554f04b
to
a32db9b
Compare
The `verdi` entry point now uses the `ProfileParamType` for its `-p` option, which enables tab-completion for the profile option. In addition, we add the loaded profile to the `obj` attribute of the click context `ctx`. This way, when a `verdi` sub commands needs the active profile, one can simply use the `@click.pass_context` decorator to access the profile through `ctx.obj.profile`.
sphuber
force-pushed
the
fix_2344_verdi_profile_param_type
branch
from
a32db9b
to
809ae80
Compare
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2344
The
verdientry point now uses theProfileParamTypefor its-poption, which enables tab-completion for the profile option.
In addition, we add the loaded profile to the
objattribute of theclick context
ctx. This way, when averdisub commands needs theactive profile, one can simply use the
@click.pass_contextdecoratorto access the profile through
ctx.obj.profile.