Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let verdi help return exit status 0 #2434

Merged
merged 2 commits into from
Jan 31, 2019
Merged

let verdi help return exit status 0 #2434

merged 2 commits into from
Jan 31, 2019

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jan 31, 2019

fix #2355

@coveralls
Copy link

coveralls commented Jan 31, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 48.005% when pulling 2d3a80a on ltalirz:issue_2355_verdi_help_exit_status into d4ddb6b on aiidateam:release_v0.12.3.

@yakutovicha yakutovicha merged commit d8f8ff1 into aiidateam:release_v0.12.3 Jan 31, 2019
@yakutovicha yakutovicha mentioned this pull request Jan 31, 2019
Closed
@sphuber
Copy link
Contributor

sphuber commented Jan 31, 2019

@yakutovicha for single commit PRs, please use the squash and merge functionality. Otherwise we get a lot of useless merge commits. We already maintain this approach in develop

@yakutovicha
Copy link
Contributor

@sphuber
ok. sorry.

@sphuber
Copy link
Contributor

sphuber commented Feb 1, 2019

Not to worry, just an FYI 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ltalirz @coveralls @sphuber @yakutovicha