Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node label in the tree end point response #2511

Merged
merged 4 commits into from
Feb 22, 2019

Conversation

waychal
Copy link
Contributor

@waychal waychal commented Feb 21, 2019

Added missing node label in the response of rest api tree endpoint.

@ltalirz
Copy link
Member

ltalirz commented Feb 21, 2019

Could you perhaps add one test?
Or is accessing the nodelabel already tested?

@coveralls
Copy link

coveralls commented Feb 21, 2019

Coverage Status

Coverage increased (+0.006%) to 56.049% when pulling f111f2d on waychal:tree_endpoint into c6426c0 on aiidateam:release_v0.12.3.

@waychal
Copy link
Contributor Author

waychal commented Feb 21, 2019

@ltalirz there is test available for tree endpoint. We do not specifically check the information passed for every node or edge.

@ltalirz
Copy link
Member

ltalirz commented Feb 21, 2019

We do not specifically check the information passed for every node or edge.

Perhaps we could change this situation? ;-)

Does not have to be entirely exhaustive but checking at least once for each key that the expected value is returned would seem reasonable, no?

@waychal
Copy link
Contributor Author

waychal commented Feb 21, 2019

I have updated the test where the important attributes displayed for node in front end are checked in response json data.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@waychal waychal merged commit bbfc73c into aiidateam:release_v0.12.3 Feb 22, 2019
@ltalirz ltalirz added this to PRs to be cherry-picked in Port from 0.12.3 into develop Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Port from 0.12.3 into develop
  
PRs to be cherry-picked
Development

Successfully merging this pull request may close these issues.

None yet

4 participants