Rename ParameterData to Dict
#2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2398_parameter_data_to_dict
branch
from
45edded
to
32b5b78
Compare
sphuber
force-pushed
the
fix_2398_parameter_data_to_dict
branch
from
32b5b78
to
c026b20
Compare
|
@giovannipizzi this one is also ready for review. Don't worry about the test failing, that is just pre-commit yapf error after rebase. |
sphuber
force-pushed
the
fix_2398_parameter_data_to_dict
branch
2 times, most recently
from
d0d100c
to
3d001e7
Compare
sphuber
force-pushed
the
fix_2398_parameter_data_to_dict
branch
from
3d001e7
to
c69f1b6
Compare
giovannipizzi
approved these changes
Feb 26, 2019
|
We'll have a proper funeral once we release the beta, we'll celebrate the beautiful life it has had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398