bug fix for verdi node delete

[zhubonan]

Fix a bug such that if no argument is passed to verdi node delete. It will try to delete ALL notes in the database.
This is because QueryBuilder().append(Node, filters={'or': []}, project='id').all() match to every single node and projects its id.

Perhaps this behaviour of QueryBuilder is not as expected? It makes more sense if an exception is raised when the 'or' list contains no element at all. I am not sure if it is still the case in 1.0.0 versions.

[coveralls]

Coverage decreased (-0.008%) to 56.061% when pulling f1bc36c on zhubonan-patch-1 into f757e55 on release_v0.12.3.

[ltalirz]

@zhubonan thanks for the bug report & the fix!

Perhaps this behaviour of QueryBuilder is not as expected? It makes more sense if an exception is raised when the 'or' list contains no element at all.

As a general rule, I think it makes sense if an "empty" or condition is true.
This can be helpful in nested, autogenerated logic trees where you are passing a list of conditions into "or" that may or may not contain elements.

I can see why it may look a bit confusing, but I think it will also be rare that a user writes {'or': []} by hand.

The bug here is that not providing a node PK results in no filter being applied (rather than doing nothing because of the missing command line arguments).

[zhubonan]

I see. Thanks.

[ltalirz]

Just checked that provenance_redesign is not affected.