New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add order options to verdi process list
#3002
add order options to verdi process list
#3002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great options. Just a small name change request and it would be good if you could at a simple test to aiida.backends.tests.cmdline.commands.process
.
@@ -280,6 +280,11 @@ def active_process_states(): | |||
type=click.Choice(['id', 'ctime']), default='ctime', show_default=True, | |||
help='Order the entries by this attribute.') | |||
|
|||
ORDER_DIR = OverridableOption( | |||
'-D', '--order-dir', 'order_dir', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use an abbreviation here, i.e. let's use --order-direction
, especially since the flags are tab completed
@@ -280,6 +280,11 @@ def active_process_states(): | |||
type=click.Choice(['id', 'ctime']), default='ctime', show_default=True, | |||
help='Order the entries by this attribute.') | |||
|
|||
ORDER_DIR = OverridableOption( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also name this ORDER_DIRECTION
Also a question: why do your PR branches always have a commit with message |
…put` (aiidateam#2995) Include the return value and content of `stdout` and `stderr`.
…ll/aiida_core into verdi-proc-list-order
…ll/aiida_core into verdi-proc-list-order
Yeh its because of that that stupid |
If your fork's
The key is to push to your fork again, otherwise you will only just fix it locally.
And then make a PR off of that branch.
|
As it says on the tin! Particularly helpful if you want to list the last x processes, i.e.
verdi process list -D desc -l 10