Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the verdi process call-root command #3091

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jun 27, 2019

Fixes #1150

This command will go up the call stack for a given process node and
return the root caller, if there is one.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.0%) to 73.76% when pulling cda258d on sphuber:fix_1150_verdi_process_call_root into 5e59da4 on aiidateam:develop.

@coveralls
Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage increased (+0.006%) to 73.957% when pulling 8401868 on sphuber:fix_1150_verdi_process_call_root into f83c67b on aiidateam:develop.

@sphuber sphuber force-pushed the fix_1150_verdi_process_call_root branch from cda258d to 8c8eae9 Compare June 27, 2019 14:58
@giovannipizzi
Copy link
Member

Wouldn't it be even more useful to implement instead a verdi callstack with the whole stack from root to current? (and maybe with an optional flag to see also called processes)? This would implicitly give the required info, but also much more

@sphuber
Copy link
Contributor Author

sphuber commented Jun 27, 2019

The callstack is already implemented in verdi process status. This command serves simply to find the call-root. Its output is not graphical in anyway, it just prints a pk. The idea is that the result of this command can be piped into another one, e.g.:

verdi process status $(verdi process call-root 901)

Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the clarification!

This command will go up the call stack for a given process node and
return the root caller, if there is one.
@sphuber sphuber force-pushed the fix_1150_verdi_process_call_root branch from 8c8eae9 to 8401868 Compare June 28, 2019 06:42
@sphuber sphuber merged commit e232f94 into aiidateam:develop Jun 28, 2019
@sphuber sphuber deleted the fix_1150_verdi_process_call_root branch June 28, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'verdi node getcallroot' command
3 participants