Remove physical constants from aiida.common.constants
#3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
approved these changes
Aug 29, 2019
These constants were added for the Quantum ESPRESSO specific code. The only constant still used was `bohr_to_ang` which was only used in a specific visualization method for the `TrajectoryData` class. This is now inlined where it is used and the constants are deleted.
sphuber
force-pushed
the
fix_161_remove_physical_constants
branch
from
27abb58
to
d58f464
Compare
sphuber
changed the title
aiida.common.constantsaiida.common.constants
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Sep 30, 2019
These constants were added for the Quantum ESPRESSO specific code. The only constant still used was `bohr_to_ang` which was only used in a specific visualization method for the `TrajectoryData` class. This is now inlined where it is used and the constants are deleted.
d-tomerini
pushed a commit
to d-tomerini/aiida_core
that referenced
this pull request
Oct 16, 2019
These constants were added for the Quantum ESPRESSO specific code. The only constant still used was `bohr_to_ang` which was only used in a specific visualization method for the `TrajectoryData` class. This is now inlined where it is used and the constants are deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
These constants were added for the Quantum ESPRESSO specific code. The
only constant still used was
bohr_to_angwhich was only used in aspecific visualization method for the
TrajectoryDataclass. This isnow inlined where it is used and the constants are deleted.
Blocked until next beta version is released