Fix UpfData constructor not forwarding filename argument
#3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature to set the desired filename of `SinglefileData` nodes and its subclasses was recently added, but the constructor of `UpfData` was not properly forwarding the new argument, causing it to be ignored.
ltalirz
approved these changes
Nov 14, 2019
ba, I did the review so equally guilty :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3542
The feature to set the desired filename of
SinglefileDatanodes andits subclasses was recently added, but the constructor of
UpfDatawasnot properly forwarding the new argument, causing it to be ignored.