Fix false positive for verdi database integrity detect-invalid-links
#3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query `SELECT_CALCULATIONS_WITH_OUTGOING_CALL` defined in the module `aiida.manage.database.integrity.sql.links` contained an error causing the command to return false positives. The problem was not detected by the tests because they operated on an empty database and only checked for true positives. A basic graph is added to now detect the false ones.
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3539
The query
SELECT_CALCULATIONS_WITH_OUTGOING_CALLdefined in the moduleaiida.manage.database.integrity.sql.linkscontained an error causingthe command to return false positives. The problem was not detected by
the tests because they operated on an empty database and only checked
for true positives. A basic graph is added to now detect the false ones.