Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set job poll interval to zero in localhost pytest fixture. #3605

Merged

Conversation

greschd
Copy link
Member

@greschd greschd commented Dec 4, 2019

In the aiida_localhost fixture, set the "minimum job poll interval" to zero. This should in general make tests using this computer quicker.

@greschd greschd requested a review from sphuber December 4, 2019 19:55
@ltalirz
Copy link
Member

ltalirz commented Dec 5, 2019

This is definitely how it should be - I'm just wondering why is it necessary to specify this explicitly?
Rather than forcing 0 here, shouldn't we make 0 the default for local computers?

@greschd
Copy link
Member Author

greschd commented Dec 5, 2019

It's definitely not the default now - note that this is different from the "safe interval" defined in the transport.

As to why the default is different @sphuber probably knows more. Maybe it's to avoid idling with high CPU load? I can see this as being an ok default for production loads if there is such a tradeoff.

@ltalirz
Copy link
Member

ltalirz commented Dec 5, 2019

Hm... for running on your laptop or workstation I think you will very likely want to set it to 0.
Of course if you install AiiDA directly on the cluster, then a finite number makes sense.

@ltalirz ltalirz self-requested a review December 5, 2019 09:22
Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@sphuber sphuber merged commit 4de836c into aiidateam:develop Dec 12, 2019
@sphuber sphuber deleted the set_poll_interval_localhost_fixture branch December 12, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants