Cache entrypoints in group #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltalirz
force-pushed
the
cache-entrypoints-in-group
branch
from
030f1b3
to
b6fe7da
Compare
greschd
reviewed
Dec 9, 2019
aiida/plugins/entry_point.py
Outdated
| @@ -50,6 +50,28 @@ class EntryPointFormat(enum.Enum): | |||
| MINIMAL = 3 | |||
|
|
|||
|
|
|||
| class EntryPointCache(): | |||
There was a problem hiding this comment.
I think this might be equivalent to adding the @functools.lru_cache(maxsize=None) decorator to the get_entry_points function.
There was a problem hiding this comment.
Good point @greschd , yes this would be a better way to do it
There was a problem hiding this comment.
Thanks, that seems to be much more elegant
ltalirz
force-pushed
the
cache-entrypoints-in-group
branch
2 times, most recently
from
60c9114
to
3f0a43b
Compare
Entry point loading is already cached at the `reentry` level but getting all entry points within a group can still take significant amount of time. This commit introduces a simple cache at the AiiDA level. An alternative would be to add a cache at the reentry level. To provide some context: The timings on a query for 300 Dict nodes are as follows: * No cache: ~110 ms * Cache: 67ms * Cache at `load_node_class` level: 58ms
ltalirz
force-pushed
the
cache-entrypoints-in-group
branch
from
3f0a43b
to
e51e7d8
Compare
|
The There is a C implementation of the cache: https://pypi.org/project/fastcache/ |
|
So you want to go with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entry point loading is already cached at the
reentrylevel but gettingall entry points within a group can still take significant amount of
time.
This commit introduces a simple cache at the AiiDA level. An alternative
would be to add a cache at the reentry level.
To provide some context: The timings on a query for 300 Dict nodes are
as follows:
load_node_classlevel: 58ms@muhrin I would say the savings are significant and probably worth reaping. Of course, one could also try to do this at the reentry side...
Let me know. If you think we keep the cache here, I'll add the proper docstrings etc.