add non-zero exit code for verdi daemon status #3729
Conversation
There was a problem hiding this comment.
I think we should add at least one unit test for this. Are you sure this works as intended? The client.get_status() always returns a dictionary, if daemon is running:
{
'status': 'active',
'time': 1580203422.571316,
'id': '10a66cd1592a44869cd632a059aab974'
}
and if it is not:
{'status': 'daemon-error-not-running'}
So I think this command currently will always exit with 1
ltalirz
force-pushed
the
issue_3728_daemon_status
branch
from
99acada
to
289b458
Compare
|
Thanks for paying attention - I actually planned doing what I did now, no idea what I was thinking... |
ltalirz
force-pushed
the
issue_3728_daemon_status
branch
from
289b458
to
5817e9e
Compare
`verdi daemon status` was always returning exit code 0, which makes it difficult to use the command programmatically (e.g. in ansible). It now returns exit code 1 if the daemon of any of the requested profiles is not running.
ltalirz
force-pushed
the
issue_3728_daemon_status
branch
from
5817e9e
to
0fd706d
Compare
aiida/cmdline/commands/cmd_daemon.py
Outdated
| """Print the status of the current daemon or all daemons.""" | ||
| """Print the status of the current daemon or all daemons. | ||
|
|
||
| Returns exit code 0 if all daemons are running, else exit code 3. |
There was a problem hiding this comment.
Could you please clarify that "all daemons" refers to "all daemons whose status is requested" and not "daemons of all profiles", i.e., if one does not specify --all then 0 is returned when the current default daemon/profile is running, even if any other daemon is not running
ltalirz
force-pushed
the
issue_3728_daemon_status
branch
from
0fd706d
to
74221b3
Compare
fixes #3728
verdi daemon statuswas always returning exit code 0, which makes itdifficult to use the command programmatically (e.g. in ansible).
It now returns exit code 1 if the daemon of any of the requested
profiles is not running.