Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix import of urllib #3767

Merged
merged 3 commits into from
Feb 21, 2020
Merged

fix import of urllib #3767

merged 3 commits into from
Feb 21, 2020

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Feb 18, 2020 •
edited
Loading

fix #3766

"import urllib" does not make the urllib.request, urllib.error modules
available.

@ltalirz
fix import of urllib
7c62215 
"import urllib" does not make the urllib.request, urllib.error modules
available.
CasperWA
CasperWA previously approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have you searched through the code base to find other imports of urllib where the import should be more explicit?

@ltalirz
Copy link
Member Author

ltalirz commented Feb 18, 2020

Good point, I've adapted the other explicit imports as well now.

CasperWA
CasperWA approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. Merge when ready 👍

@sphuber sphuber merged commit 11cefed into aiidateam:develop Feb 21, 2020
@sphuber sphuber deleted the issue_3766_urllib_import branch February 21, 2020 08:13
@sphuber
Copy link
Contributor

sphuber commented Feb 21, 2020

Thanks @ltalirz

csadorf pushed a commit that referenced this pull request Mar 5, 2020
@ltalirz @csadorf
Fix broken imports of urllib (#3767)
18de7b4 
`import urllib` does not automatically make the `urllib.request`
and `urllib.error` modules available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verdi import from URL broken
3 participants
@ltalirz @sphuber @CasperWA