BaseRestartWorkChain: require process handlers to be instance methods
#3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_3780_base_restart_restrict_registering
branch
2 times, most recently
from
b5abd1e
to
8f04725
Compare
yakutovicha
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Thanks, @sphuber.
Just a few comments, questions. I did not try to run it myself yet.
The original implementation of the `register_process_handler` allowed an unbound method to be bound to a subclass of `BaseRestartWorkChain` outside of its scope. Since this also makes it possible to attach these process handlers from outside of the module of the work chain, this will run the risk of the loss of provenance. Here we rename the decorator to `process_handler` and it can only be applied to instance methods. This forces the handlers to be defined in the same module as the work chain to which they apply.
sphuber
force-pushed
the
fix_3780_base_restart_restrict_registering
branch
from
8f04725
to
ee676c2
Compare
yakutovicha
approved these changes
Feb 21, 2020
csadorf
pushed a commit
that referenced
this pull request
Mar 5, 2020
…ds (#3782) The original implementation of the `register_process_handler` allowed an unbound method to be bound to a subclass of `BaseRestartWorkChain` outside of its scope. Since this also makes it possible to attach these process handlers from outside of the module of the work chain, this will run the risk of the loss of provenance. Here we rename the decorator to `process_handler` and it can only be applied to instance methods. This forces the handlers to be defined in the same module as the work chain to which they apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3780
The original implementation of the
register_process_handlerallowed anunbound method to be bound to a subclass of
BaseRestartWorkChainoutside of its scope. Since this also makes it possible to attach these
process handlers from outside of the module of the work chain, this will
run the risk of the loss of provenance. Here we rename the decorator to
process_handlerand it can only be applied to instance methods. Thisforces the handlers to be defined in the same module as the work chain
to which they apply.