Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add append and prepend to aiida_local_code_factory #3831

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

ezpzbz
Copy link
Member

@ezpzbz ezpzbz commented Mar 4, 2020

This PR aims to add the ability of adding append_text and prepend_text to the aiida_local_code_factory which is need in writing tests for codes where we need to have these extra fields.

@greschd
Copy link
Member

greschd commented Mar 4, 2020

Looks useful to me, thanks! To keep consistent with the naming of the Code attribute, I would probably call the keyword arguments prepend_text and append_text (even if it's a bit more verbose).

@ezpzbz
Copy link
Member Author

ezpzbz commented Mar 4, 2020

Thanks @greschd. I just applied your suggestion and pushed the changes.

greschd
greschd previously requested changes Mar 4, 2020
Copy link
Member

@greschd greschd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just the docstring needs updating also. I'll leave it up to @ltalirz to merge this.

aiida/manage/tests/pytest_fixtures.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #3831 into develop will decrease coverage by 7.96%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #3831      +/-   ##
==========================================
- Coverage    77.16%   69.2%   -7.97%     
==========================================
  Files          458     458              
  Lines        33766   33770       +4     
==========================================
- Hits         26056   23369    -2687     
- Misses        7710   10401    +2691
Flag Coverage Δ
#django 69.2% <60%> (-0.01%) ⬇️
#sqlalchemy ?
Impacted Files Coverage Δ
aiida/manage/tests/pytest_fixtures.py 87.75% <60%> (-3.36%) ⬇️
...ions/versions/91b573400be5_prepare_schema_reset.py 0% <0%> (-100%) ⬇️
aiida/backends/sqlalchemy/utils.py 0% <0%> (-100%) ⬇️
...ns/5ddd24e52864_dbnode_type_to_dbnode_node_type.py 0% <0%> (-100%) ⬇️
...ions/d254fdfed416_rename_parameter_data_to_dict.py 0% <0%> (-100%) ⬇️
...ons/7ca08c391c49_calc_job_option_attribute_keys.py 0% <0%> (-100%) ⬇️
.../versions/ea2f50e7f615_dblog_create_uuid_column.py 0% <0%> (-100%) ⬇️
...emy/migrations/versions/e797afa09270_reset_hash.py 0% <0%> (-100%) ⬇️
...ations/versions/118349c10896_default_link_label.py 0% <0%> (-100%) ⬇️
...30c8430131_drop_node_columns_nodeversion_public.py 0% <0%> (-100%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba83912...d5823d9. Read the comment docs.

@sphuber sphuber self-requested a review March 4, 2020 21:33
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks @pzarabadip 👍

@sphuber sphuber merged commit ed7a0b6 into aiidateam:develop Mar 4, 2020
@ezpzbz ezpzbz deleted the pytest_fixture branch March 5, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants