Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the -l/--limit option to verdi group show #3857

Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Mar 21, 2020

Fixes #3855

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #3857 into develop will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3857      +/-   ##
===========================================
- Coverage    77.17%   77.16%   -0.02%     
===========================================
  Files          458      458              
  Lines        33770    33774       +4     
===========================================
- Hits         26063    26062       -1     
- Misses        7707     7712       +5
Flag Coverage Δ
#django 69.2% <83.33%> (ø) ⬆️
#sqlalchemy 70.02% <83.33%> (-0.02%) ⬇️
Impacted Files Coverage Δ
aiida/cmdline/commands/cmd_group.py 89.3% <83.33%> (+0.23%) ⬆️
aiida/orm/utils/log.py 76.66% <0%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b89c1...ec35a0b. Read the comment docs.

@sphuber
Copy link
Contributor Author

sphuber commented Mar 21, 2020

Can @CasperWA or @csadorf maybe explain why codecov reports that the coverage decreases? Why do these changes affect aiida.orm.utils.log at all?

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sphuber

@ltalirz ltalirz merged commit b90a629 into aiidateam:develop Mar 22, 2020
@csadorf
Copy link
Contributor

csadorf commented Mar 23, 2020

@sphuber I am puzzled by that myself and already inquired about that as part of this test PR: #3850

@sphuber sphuber deleted the feature/3855/verdi-group-show-limit branch March 23, 2020 10:37
@sphuber
Copy link
Contributor Author

sphuber commented Mar 23, 2020

@sphuber I am puzzled by that myself and already inquired about that as part of this test PR: #3850

I see, thanks for the comment. If I understand your conclusion in that PR correctly, it means that this can happen "randomly" and there is no way to prevent this systematically? I guess that is also why the codecov actions are not yet marked as required for passing a PR, correct? I take it that will have to remain if the chance remains that it can fail arbitrarily, which would block an otherwise perfectly fine PR from being merged.

@csadorf
Copy link
Contributor

csadorf commented Mar 23, 2020

@sphuber I don't think that this really happens randomly. At least I have not yet observed this behavior in other projects that used codecov. I presume that something went wrong during the initial setup and that this weird behavior will eventually go away. We should revisit in a few weeks if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add limit option to verdi group show
3 participants