Allow verdi calcjob outputcat work with binary files

[zhubonan]

Fixes #4086

This PR allows verdi calcjob outputcat to work with binary files such as those compressed by gzip. Previously, only plain text files can be printed because of the missing parameter mode in get_object_content, which defaults to r.

Edit:

Now just open the file as it is in bytes, and use shutil.copyfileobj to do the copying. This function copies the content in chunks and avoids high memory usage. The command should now work with both text files and binary data.

[codecov]

Codecov Report

Merging #4077 into develop will increase coverage by 0.02%.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##           develop    #4077      +/-   ##
===========================================
+ Coverage    78.76%   78.78%   +0.02%     
===========================================
  Files          463      463              
  Lines        34402    34414      +12     
===========================================
+ Hits         27095    27108      +13     
+ Misses        7307     7306       -1     

Flag	Coverage Δ
#django	70.69% <62.50%> (+0.02%)	⬆️
#sqlalchemy	71.57% <62.50%> (+0.02%)	⬆️

Impacted Files	Coverage Δ
aiida/cmdline/commands/cmd_calcjob.py	68.80% <62.50%> (+0.38%)	⬆️
aiida/cmdline/commands/cmd_node.py	82.57% <62.50%> (+0.90%)	⬆️
aiida/transports/plugins/local.py	80.21% <0.00%> (-0.25%)	⬇️
aiida/engine/daemon/client.py	73.72% <0.00%> (+1.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ea47d...a80b85d. Read the comment docs.

[giovannipizzi]

Some minor comments

[giovannipizzi]

BTW, since you are at it, probably you might want to:

• fix also inputcat, and the cat command of verdi node repo, if it has the same issue?
• add some tests?

[zhubonan]

@giovannipizzi Done! I have also added the tests.

[sphuber]

Looking good @zhubonan , thanks a lot. There is also verdi node repo cat that suffers from the same problem. Would you be willing to add your fix there as well?

[zhubonan]

@sphuber i thinks that has been fixed as well in the latest pushes (please do double check). It is really to merge now.

[sphuber]

Thanks a lot @zhubonan