NodeTranslator: do not assume get_export_formats exists
#4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_all_download_formats` will try to call `get_export_formats` on all the known plugin types. However, it is not guaranteed that all plugins implement this method. This was properly considered in the case that `full_type` is not None, however, in the other case the `AttributeError` was not being caught causing the REST API to except.
Codecov Report
@@ Coverage Diff @@
## develop #4188 +/- ##
===========================================
+ Coverage 78.93% 78.94% +0.01%
===========================================
Files 467 467
Lines 34505 34501 -4
===========================================
Hits 27232 27232
+ Misses 7273 7269 -4
Continue to review full report at Codecov.
|
giovannipizzi
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4185
The
get_all_download_formatswill try to callget_export_formatsonall the known plugin types. However, it is not guaranteed that all
plugins implement this method. This was properly considered in the case
that
full_typeis not None, however, in the other case theAttributeErrorwas not being caught causing the REST API to except.