Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update paramiko to 2.7 #4222

Merged
merged 1 commit into from
Aug 26, 2020
Merged

update paramiko to 2.7 #4222

merged 1 commit into from
Aug 26, 2020

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jul 6, 2020

Version 2.7 of paramiko finally brings support for the OpenSSH private
key format, which has been the default on MacOS for some time.

See paramiko/paramiko#1343

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #4222 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4222      +/-   ##
===========================================
+ Coverage    79.17%   79.17%   +0.01%     
===========================================
  Files          468      468              
  Lines        34467    34467              
===========================================
+ Hits         27285    27286       +1     
+ Misses        7182     7181       -1     
Flag Coverage Δ
#django 71.09% <ø> (+0.01%) ⬆️
#sqlalchemy 71.93% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
aiida/transports/plugins/local.py 80.47% <0.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af3b48...87b1e8f. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #4222 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4222   +/-   ##
========================================
  Coverage    79.04%   79.04%           
========================================
  Files          468      468           
  Lines        34610    34610           
========================================
  Hits         27354    27354           
  Misses        7256     7256           
Flag Coverage Δ
#django 72.66% <ø> (ø)
#sqlalchemy 71.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5977dac...510d860. Read the comment docs.

Version 2.7 of paramiko finally brings support for the OpenSSH private
key format, which has been the default on MacOS for some time.
@ltalirz ltalirz added this to the v1.4.0 milestone Aug 26, 2020
@ltalirz ltalirz marked this pull request as ready for review August 26, 2020 09:39
@ltalirz ltalirz requested a review from sphuber August 26, 2020 09:40
@sphuber
Copy link
Contributor

sphuber commented Aug 26, 2020

I am a bit confused. Shouldn't there also be an automated bot/runner that checks the requirements/requirements*.txt files and update the paramiko version in there? @csadorf how does this work again?

@ltalirz
Copy link
Member Author

ltalirz commented Aug 26, 2020

Shouldn't there also be an automated bot/runner that checks the requirements/requirements*.txt files

There is, but the paramiko version there is already 2.7.x . This PR just increases the minimum required version.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, thanks

@sphuber sphuber merged commit ac801c9 into aiidateam:develop Aug 26, 2020
@sphuber sphuber deleted the update-paramiko branch August 26, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants