verdi status: do not except when no profile is configured
#4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/4250/verdi-status-no-profile
branch
from
d130083
to
a56291d
Compare
|
Thanks @chrisjsewell . All comments are addressed. |
Instead, print that no profile could be found and suggest that one is setup with `verdi quicksetup` or `verdi setup`. To test this, a new pytest fixture is created that creates a completely new and independent configuration folder, along with fixtures to create profiles to add to the config and caching configuration files. Similar code already exists for normal unittests, but this can be removed once those have been refactored to pytests.
sphuber
force-pushed
the
fix/4250/verdi-status-no-profile
branch
from
a56291d
to
0fbc274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4250
Instead, print that no profile could be found and suggest that one is
setup with
verdi quicksetuporverdi setup.To test this, a new pytest fixture is created that creates a completely
new and independent configuration folder, along with fixtures to create
profiles to add to the config and caching configuration files. Similar
code already exists for normal unittests, but this can be removed once
those have been refactored to pytests.