Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: limit upper version of setuptools<50 for Jenkins build #4343

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Sep 1, 2020

Fixes #4342

Builds on Jenkins started failing after setuptools==0.50.0 was
released on August 30, 2020. This new version gets automatically
installed when using a pyproject.toml for the build system, but it
causes the installation of the aiida-core package through pip to
fail with the exception:

ModuleNotFoundError: No module named 'setuptools._distutils'

Temporarily limiting the version of setuptools in the pyproject.toml
works around the problem for the time being.

The build is updated to also update the version of pip before
installing the package.

@sphuber
Copy link
Contributor Author

sphuber commented Sep 1, 2020

Builds on Jenkins started failing after `setuptools==0.50.0` was
released on August 30, 2020. This new version gets automatically
installed when using a `pyproject.toml` for the build system, but it
causes the installation of the `aiida-core` package through `pip` to
fail with the exception:

    ModuleNotFoundError: No module named 'setuptools._distutils'

Temporarily limiting the version of `setuptools` in the `pyproject.toml`
works around the problem for the time being.

The build is updated to also update the version of `pip` before
installing the package.
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #4343 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4343      +/-   ##
===========================================
+ Coverage    79.14%   79.16%   +0.03%     
===========================================
  Files          468      468              
  Lines        34616    34616              
===========================================
+ Hits         27395    27402       +7     
+ Misses        7221     7214       -7     
Flag Coverage Δ
#django 72.77% <ø> (+0.01%) ⬆️
#sqlalchemy 71.97% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.54% <0.00%> (+0.26%) ⬆️
aiida/engine/daemon/runner.py 82.76% <0.00%> (+3.45%) ⬆️
aiida/orm/utils/log.py 93.34% <0.00%> (+16.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44fe2a7...de71581. Read the comment docs.

@sphuber sphuber added the pr/on-hold PR should not be merged label Sep 1, 2020
@sphuber
Copy link
Contributor Author

sphuber commented Sep 1, 2020

Put this PR on hold to see if a fix downstream becomes available in a day or two that makes the fix obsolete. Otherwise we will merge

@sphuber
Copy link
Contributor Author

sphuber commented Sep 3, 2020

One user in the above mentioned thread, actually argues it is a bug in pip and not setuptools. They describe their that they suspect that using a virtualenv with --system-site-packages breaks pip's build isolation. I tried looking into the Jenkins configuration file what type of environment is used, but it looks to me like we are not even using a virtual env at all? @giovannipizzi is that true? If that is the case, then there might be another reason for the problem we have been seeing. Anyway, it doesn't seem like there will be a fix downstream, so I think we should just merge this.

@sphuber sphuber merged commit 0f0dda4 into develop Sep 3, 2020
@sphuber sphuber deleted the fix/jenkins branch September 3, 2020 10:03
@csadorf csadorf removed the pr/on-hold PR should not be merged label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins build started failing
2 participants