verdi migrate --in-place between file systems

[ltalirz]

fix #4392

verdi import --in-place assumed that the temporary directory for the
migrated archive and the working directory are on the same file system.
If that was not the case, it would crash with

OSError: [Errno 18] Invalid cross-device link

Switching from os.rename to shutil.move should resolve this issue.

[codecov]

Codecov Report

Merging #4393 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #4393      +/-   ##
===========================================
- Coverage    79.36%   79.35%   -0.00%     
===========================================
  Files          476      476              
  Lines        34950    34951       +1     
===========================================
- Hits         27734    27733       -1     
- Misses        7216     7218       +2     

Flag	Coverage Δ
#django	73.22% <100.00%> (+0.01%)	⬆️
#sqlalchemy	72.45% <100.00%> (-<0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiida/cmdline/commands/cmd_export.py	90.98% <100.00%> (+0.07%)	⬆️
aiida/engine/daemon/client.py	72.42% <0.00%> (-1.14%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 861a39f...ee50227. Read the comment docs.

[greschd]

Just to mention: While os.rename is guaranteed to be atomic (on Linux), AFAIK think shutil.move makes no such promises. I guess that's why it's able to move between file systems in the first place.

Not sure if that's a guarantee that we need here - I guess it would be nice to be protected against corruption of the in-place-migrated archive. But then again, one can also not do it in place in cases where that's really important.