🔧 Add patch threshold for codecov #4413
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4413 +/- ##
========================================
Coverage 79.23% 79.23%
========================================
Files 475 475
Lines 34826 34826
========================================
Hits 27591 27591
Misses 7235 7235
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Great if this can get rid of false positives of failing builds due to so-called reduced coverage. However, I definitely think we need to up the threshold. The 0.02% is based on all the lines in the project which is huge. Very few patches will come close. I am thinking 0.1% would already be a lot more reasonable don't you think? With 0.02% we would still see the false positives very often I think
|
absolutely, just changed |
The project diff percentage is the change in coverage w.r.t. all lines in the project, whereas the patch diff percentage is the change in coverage w.r.t. only lines touched by the PR
The patch threshold is currently defaulting to 0%, hence it is very easy to fail.
You might even want to increase this threshold, since a smaller amount of uncovered lines will lead to a larger diff percentage, relative to the project diff.