cmdline/data/struct/import: add --label and --group options #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dev-zero , thanks for the contribution! The code looks perfectly fine as it is, but could I ask you to include some tests for these new options? |
dev-zero
force-pushed
the
feature/structure-import-label-and-group
branch
from
c28c9c9
to
6e43515
Compare
|
@ramirezfranciscof done |
dev-zero
force-pushed
the
feature/structure-import-label-and-group
branch
from
6e43515
to
787fcfc
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4429 +/- ##
===========================================
+ Coverage 79.50% 79.51% +0.01%
===========================================
Files 519 519
Lines 37077 37089 +12
===========================================
+ Hits 29473 29486 +13
+ Misses 7604 7603 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ramirezfranciscof
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Thanks @dev-zero! I'll update the branch and merge after passing tests. Sorry for the delay in the review process 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.