Fix ZeroDivisionError in worker slots check
#4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if someone could just give this the seal of approval 😄 |
ltalirz
approved these changes
Oct 25, 2020
There was a problem hiding this comment.
thanks @chrisjsewell , that seems an obvious fix.
I'd also say that percent_load is a misnomer here; load_ratio (or just load) would be better but I leave it up to you whether you want to fix this as well.
Cheers, nah can't be bothered to wait for the tests again lol |
|
hmm I hope there is not an issue with jenkins |
In any case, it has already passed on the PR, so you can merge |
|
seems ok but just not being reported back:
|
chrisjsewell
changed the title
ZeroDivisionError in worker slots check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4512