RabbitMQ: remove validation of broker_parameters from profile
#4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validation was added as an attempt to help users with detecting invalid parameters in the `broker_parameters` dictionary of a profile, but `aiida-core` internally has no real limitations here. It is the libraries underneath that decide what is acceptable and this can differ from library to library plus it is not always clear. For example, currently we use `topika` and `pika` which behave different from `aiormq` which will be replacing them soon once `tornado` is replaced with `asyncio`. It is best to not limit the options on `aiida-core`'s side and just let it fail downstream as to not artificially limit the parameters that might be perfectly acceptable by the libraries downstream.
Codecov Report
@@ Coverage Diff @@
## release/1.4.3 #4542 +/- ##
=================================================
+ Coverage 79.23% 79.23% +0.01%
=================================================
Files 475 475
Lines 34832 34828 -4
=================================================
- Hits 27595 27592 -3
+ Misses 7237 7236 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@muhrin @ramirezfranciscof I had the contact person at LLNL test this branch and they confirmed it still works with their environment, so this should be good to merge. Then I will prepare the 1.4.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4540
This validation was added as an attempt to help users with detecting
invalid parameters in the
broker_parametersdictionary of a profile,but
aiida-coreinternally has no real limitations here. It is thelibraries underneath that decide what is acceptable and this can differ
from library to library plus it is not always clear. For example,
currently we use
topikaandpikawhich behave different fromaiormqwhich will be replacing them soon oncetornadois replacedwith
asyncio. It is best to not limit the options onaiida-core'sside and just let it fail downstream as to not artificially limit the
parameters that might be perfectly acceptable by the libraries
downstream.