-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve error message for unconfigured computers #4670
Feat: Improve error message for unconfigured computers #4670
Conversation
@sphuber I still didn't add the check you wanted because I have a problem. In principle I would just need to call However, I'm not sure what user to provide or how to access it. In the case of the call inside the engine (the error shown in the issue #4645), the task was provided with the |
664159d
to
899a73f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4670 +/- ##
===========================================
+ Coverage 79.52% 79.52% +0.01%
===========================================
Files 519 519
Lines 37083 37087 +4
===========================================
+ Hits 29486 29491 +5
+ Misses 7597 7596 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
899a73f
to
cb9d9ff
Compare
Also these test failures seem to have been caused by the Open SSH upgrade - please continue with review/approval |
cb9d9ff
to
00c2c7d
Compare
55bccb3
to
ac1cdb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just only minor typo a dn one doubt where @sphuber might help, otherwise looks good to me
ac1cdb6
to
87aff8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Fixes #4645
I added a check to the
get_authinfo
method of the computer class that improves on the error raised by the call toauthinfos.AuthInfo.objects(...).get(...)
when a (computer, user) couple is not found for the requested case. Also added a test that checks for the correct error raised, and also that the critical pieces of information are present in the error message.