Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: set upper limit werkzeug<2.2 #5606

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Jul 27, 2022

The werkzeug==2.2 release is breaking the REST API causing most of the
routes to return a 404 error.

The `werkzeug==2.2` release is breaking the REST API causing most of the
routes to return a 404 error.
@sphuber
Copy link
Contributor Author

sphuber commented Jul 27, 2022

Seems that this issue of werkzeug may be the underlying cause.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #5606 (7f0e518) into main (bc73d61) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5606      +/-   ##
==========================================
+ Coverage   79.69%   79.69%   +0.01%     
==========================================
  Files         532      532              
  Lines       37928    37928              
==========================================
+ Hits        30223    30224       +1     
+ Misses       7705     7704       -1     
Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.85% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc73d61...7f0e518. Read the comment docs.

@csadorf
Copy link
Contributor

csadorf commented Jul 28, 2022

Seems that this issue of werkzeug may be the underlying cause.

A fix for this issue was released as part of Werkzeug version 2.2.1, however the test-install workflow still fails.

@sphuber
Copy link
Contributor Author

sphuber commented Aug 2, 2022

Actually probably is this bug: pallets/werkzeug#2482

@csadorf
Copy link
Contributor

csadorf commented Aug 4, 2022

Actually probably is this bug: pallets/werkzeug#2482

@sphuber Since it does not seem like the issue would be addressed in a timely manner, I suggest that we move forward with constraining the werkzeug version then (this PR).

@csadorf csadorf added the dependencies Pull requests that update a dependency file label Aug 4, 2022
@sphuber sphuber merged commit bd27aea into main Aug 4, 2022
@sphuber sphuber deleted the fix/test-install-workflow branch August 4, 2022 08:23
sphuber added a commit that referenced this pull request Feb 23, 2023
The limit was added in #5606
because the release of `werkzeug==2.2.0` was causing the REST API tests to fail,
but it seems the patch releases have solved the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants