Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine: Do not call serializer for None values #5694

Merged
merged 1 commit into from
Oct 13, 2022

Commits on Oct 13, 2022

  1. Engine: Do not call serializer for None values

    Any port that defines a `serializer`, will have that serializer invoked
    when a value is passed to this port. The invokation was correctly
    skipped if no serializer was defined or if the value already was a
    `Data` node (in which case serialization is no longer needed), but it
    was also called when this value is `None`.
    
    It arguably doesn't make sense to serialize a value that has not been
    defined. This behavior would cause problems for processes that define a
    port with a serializer but that also accept `None`. In this case the
    serializer would nevertheless be called and, in the case of the
    `to_aiida_type` serializer for example, would except.
    sphuber committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    1f5ffa4 View commit details
    Browse the repository at this point in the history