Tests: Make daemon fixtures available to plugin packages #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix/daemon-fixtures-accessible-plugins
branch
2 times, most recently
from
1874ca2
to
da9a3cc
Compare
unkcpz
requested changes
Oct 18, 2022
There was a problem hiding this comment.
@sphuber thanks! All good. Very useful and brilliant feature. Just one minor request, might be worth to add a short doc of the fixture to https://aiida.readthedocs.io/projects/aiida-core/en/latest/topics/plugins.html#plugin-test-fixtures
sphuber
force-pushed
the
fix/daemon-fixtures-accessible-plugins
branch
from
da9a3cc
to
e83b41e
Compare
|
@unkcpz I updated the test fixture docs and added the new fixtures. |
sphuber
force-pushed
the
fix/daemon-fixtures-accessible-plugins
branch
from
e83b41e
to
d2f09e8
Compare
The `conftest.py` provides useful fixtures for tests that require a started or stopped daemon client: * `started_daemon_client`: make sure daemon is running and return client * `stopped_daemon_client`: make sure daemon is stopped and return client * `submit_and_await`: submit a process or builder and wait for it to reach a particular process state. These fixtures are not just useful for tests of `aiida-core` but also for plugin packages. Therefore they are moved to the module `aiida.manage.tests.pytest_fixtures` such that they can be easily imported into the `conftest.py` of a plugin package.
sphuber
force-pushed
the
fix/daemon-fixtures-accessible-plugins
branch
from
d2f09e8
to
5329b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
conftest.pyprovides useful fixtures for tests that require a started or stopped daemon client:started_daemon_client: make sure daemon is running and return clientstopped_daemon_client: make sure daemon is stopped and return clientsubmit_and_await: submit a process or builder and wait for it to reach a particular process state.These fixtures are not just useful for tests of
aiida-corebut also for plugin packages. Therefore they are moved to the moduleaiida.manage.tests.pytest_fixturessuch that they can be easily imported into theconftest.pyof a plugin package.