Mark relevant Process exit codes as invalidates_cache=True
#5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Process` and `CalcJob` classes define various exit codes, all of which will correspond to processes that should not be used as a source for caching. Therefore, these exit codes should properly declare `invalidate_cache=True` which will automatically prevent any node with that exit code from being cached from. The `ArithmeticAddCalculation` and `TemplatereplacerCalculation plugins are also updated to properly mark exit codes that should not be cached from.
The exit codes where specified in the 100 range, which is reserved (by convention) for exit codes defined by the `CalcJob` class. In fact, some of them even overlapped with existing exit codes defined by `CalcJob`. There currently is no logic in `aiida-core` that will prevent or at least warn when existing exit codes get overwritten so this went unnoticed until now. Since the plugin is mostly used for internal testing purposes, there will not be an automated database migration to update existing exit codes.
This was referenced Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5708
The
ProcessandCalcJobclasses define various exit codes, all ofwhich will correspond to processes that should not be used as a source
for caching. Therefore, these exit codes should properly declare
invalidate_cache=Truewhich will automatically prevent any node withthat exit code from being cached from.
The
ArithmeticAddCalculationand `TemplatereplacerCalculation pluginsare also updated to properly mark exit codes that should not be cached
from.