Fixtures: make the entry_points fixture publicly available
#5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default of 5 seconds was a bit short causing certain tests to fail randomly because the expected state was just not achieved in time. Giving a timeout that is a bit more lenient will prevent these false positives while still killing tests soon enough that will hang forever otherwise.
This fixture makes it easy to temporarily add or remove entry points which comes in very handy when testing custom implementations of various classes that are pluginnable. By moving them from `tests/conftest.py` to the `aiida.manage.tests.pytest_fixtures` module, it can also be used by plugin packages.
sphuber
force-pushed
the
fix/move-entry-point-fixture-to-public
branch
from
80f51c1
to
16ab747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also increase the timeout of the
submit_and_awaitfixture which should get rid of tests failing sporadically. The five seconds timeout may have been a bit too tight.