ProfileManager: restart daemon in clear_profile
#5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `clear_profile` the storage backend will be emptied. If a daemon is running that is connected to that storage, it may still be holding references to entities that will now have been removed. As soon as the daemon will then pick up another process in a later test, it will hit an exception trying to access the entity in the database that no longer exists. To solve this, the `clear_profile` now checks whether the daemon is running before clearing the storage in which case it stops it. The daemon is not restarted because this is a costly operation. If there are many tests that clear the profile but that do not need the daemon, it is restarted for each test unnecessarily, greatly increasing test run time. Any test that requires the daemon to be started, should make sure of that itself.
Shutting down the daemon after every test is costly, especially if many tests require a daemon and so each test will start and stop the daemon as opposed to it being shut down once at the end of the session. The `daemon_client` was initially introduced as being session scoped but then changed to being function scoped because there was a subtle bug in that caused the `test_duplicate_subscriber_identifier` to fail. It only failed though when `test_revive` of `engine/processes/test_control.py` and `tests/engine/processes/calcjobs/test_calc_job.py` were run before it. The problem is that these tests use the `aiida_profile_clean` fixture which reset the storage backend. However, it doesn't restart the daemon and it may still hold on to references to entities in the database that will have been cleaned. The solution is to also restart the daemon if it was running when resetting the profile. This bug was solved in the previous commit and so now the original ideal intended scope of the `daemon_client` fixture can be reinstated.
sphuber
force-pushed
the
fix/daemon-client-fixture
branch
from
8cbd2d1
to
c39a0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.