CI: Increase load limit for verdi to 0.5 seconds
#5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the verdi load-time test has been failing frequently because the load time often exceeds the current limit of 0.4 seconds. For now we raise the limit to 0.5 to reduce the false positives while we find a permanent fix of reducing the load time.
sphuber
force-pushed
the
fix/5771/ci-verdi-load-time-limit
branch
from
0d37c5f
to
77ad804
Compare
sphuber
changed the title
verdi to 0.45 secondsverdi to 0.5 seconds
Not sure. Locally, I still get load speeds of ~0.21 seconds. I didn't notice an increase. I tried narrowing down if there are costly calls, but this is always quite finicky and I couldn't really pinpoint a bottleneck. I have also noticed quite a big spread in run times of the unit tests, ranging from ~11 to ~16 minutes. Could be that there is just a big spread in server speed on the GHA runners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5771
Recently, the verdi load-time test has been failing frequently because the load time often exceeds the current limit of 0.4 seconds. For now we raise the limit to 0.5 to reduce the false positives while we find a permanent fix of reducing the load time.